Update vitest, configure tests to run in chromium#55
Update vitest, configure tests to run in chromium#55rsilivestr wants to merge 4 commits intohttptoolkit:mainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
If you have a second can you sign the CLA above? Looks like you'll need to update the email used in your git commits to match your GitHub account first. On a more practical note, this causes issues on my machine (Linux Mint) with these changes I get failures: All passes fine for me on Any idea why? If this is now using the bundled Chromium, I would've expected identical results in Linux CI here and on my local machine. |
|
I wondered why CLA status didn't update... so this is email mismatch. Will fix it soon. Seems like chromium binary does not include necessary codecs. Yet it works for me somehow. Have you updated playwright browsers before running tests ( |
6098aea to
67cc776
Compare
Removes system-level dependency on chrome browser
67cc776 to
b06a5db
Compare
|
Ran tests on Ubuntu 20.04 and Windows 10. In both cases all tests passed. |
Fixes some tests failing due to missing video codecs
|
Okay. Figured it out. Updated required playwright version. Should work now. Also, is it a good idea to add |
Good idea 👍
Makes sense! Clearing node modules & reinstalling worked for me, but this is better. Happy to merge with the pretest script |
This PR allows to run tests without system-wide Chrome browser installation.
Resolves #54